Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor metric samples to use Atlas for tags and have time series #2594

Merged
merged 15 commits into from
Oct 4, 2022
Merged

Refactor metric samples to use Atlas for tags and have time series #2594

merged 15 commits into from
Oct 4, 2022

Commits on Oct 4, 2022

  1. Use github.com/mstoykov/atlas for the SampleTags internals

    @codebien
    codebien committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    9938a3d View commit details
    Browse the repository at this point in the history

  2. lib: Atlas migration

    @codebien
    codebien committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    d9197e1 View commit details
    Browse the repository at this point in the history

  3. Migrate the outputs to use the metrics' atlas-based types

    @codebien
    codebien committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    68a6a33 View commit details
    Browse the repository at this point in the history

  4. js: Use the new Atlas-based state.Tags

    @codebien
    codebien committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    ad6ba6f View commit details
    Browse the repository at this point in the history

  5. core,cmd: Operations for init the new Atlas-based types

    @codebien
    codebien committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    70f3877 View commit details
    Browse the repository at this point in the history

  6. Remove NewTagSet and init all tag sets from a common Registry root at… 

    …las Node
    @codebien
    codebien committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    0191e74 View commit details
    Browse the repository at this point in the history

  7. Simplify the atlas integration to just metrics.TagSet and helpers 

    This implements the consensus from the PR comment (#issuecomment-1205273413), with some minor modifications.
    @na-- @codebien
    na-- authored and codebien committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    10a0f19 View commit details
    Browse the repository at this point in the history

  8. Refactor metrics.Sample to have a comparable TimeSeries 

    This will allow metric Samples to be easily grouped with other Samples with the same metric and tags. It implements the consensus described in my second PR comment (#issuecomment-1205359198)
    @na-- @codebien
    na-- authored and codebien committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    7f929cc View commit details
    Browse the repository at this point in the history

  9. Rename TagSet.SortAndAddTags() to WithTagsFromMap() and improve comments

    @na-- @codebien
    na-- authored and codebien committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    721b2f4 View commit details
    Browse the repository at this point in the history

  10. Convert xk6-websockets to atlas-based metric tags

    @na-- @codebien
    na-- authored and codebien committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    cf16837 View commit details
    Browse the repository at this point in the history

  11. Reformat go.mod

    @codebien
    codebien committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    a03ac0b View commit details
    Browse the repository at this point in the history

  12. output/cloud: Pass error as a field for logging

    @codebien
    codebien committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    f31f716 View commit details
    Browse the repository at this point in the history

  13. lib,js: Set always the Tag URL equals to tag Name 

    After the introduction of Atlas, we decided to keep `url` as a normal tag
but it always set to have the same value of the `name` tag.
In this way, if the `url` contains high-cardinality values it wouldn't
affect the system.
This is the same thing that currently the cloud output does.
    @codebien
    codebien committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    62fd14a View commit details
    Browse the repository at this point in the history

  14. Remove experimental xk6-websockets 

    Remove for a temporary commit the experimental module to allow bumping
the k6 dependency in the extension's repository.
    @codebien
    codebien committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    50bc9af View commit details
    Browse the repository at this point in the history

  15. Bump xk6-websockets version 

    Uses the xk6-websockets main version that is now migrated to the time
series version.
    @codebien
    codebien committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    f5f05c9 View commit details
    Browse the repository at this point in the history