Fix VERSION_DETAILS does not contain the latest tag #2691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebien
previously approved these changes
Sep 22, 2022
na--
requested changes
Sep 23, 2022
There was a problem hiding this comment.
It seems like the same problem is also present in the Dockerfile:
Line 5 in 979378a
tag Add the flag to fetch all tags for the git describe.
olegbespalov
force-pushed
the
fix/2676-version-details-tag
branch
from
9d42a11
to
4c28981
Compare
codebien
approved these changes
Sep 26, 2022
mstoykov
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add a
--tagsflag to fetch all tags for thegit describe.Why?
Without that flag k6's version details gets a previous flag.
Closes: #2676