Rename samples to examples #3005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstoykov
force-pushed
the
renameSamplesToExamples
branch
from
84bea5f
to
3b5cbc2
Compare
|
I think the docker-compose should also be adjusted: https://github.com/grafana/k6/blob/master/docker-compose.yml#L40 |
Also update the name of a module in the examples that is used to test gRPC. And docker-compose.yml which mounts those.
mstoykov
force-pushed
the
renameSamplesToExamples
branch
from
3b5cbc2
to
0f7a37c
Compare
|
Nice catch! 👏 🙇 I did search for I also decided against editing some tests that are still running without a problem as those are just example strings and not actually loading the files. We can update those as well if you want, cc @olegbespalov @oleiade |
olegbespalov
approved these changes
Apr 5, 2023
na--
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.