-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for registering nested message types #3178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for your contribution! 🚀
Codecov Report
@@ Coverage Diff @@
## master #3178 +/- ##
==========================================
- Coverage 72.82% 72.76% -0.07%
==========================================
Files 255 253 -2
Lines 19611 19611
==========================================
- Hits 14281 14269 -12
- Misses 4433 4441 +8
- Partials 897 901 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
What?
client.load()
(grpc module) was not registering protobuf nested messages inprotoregistry.GlobalTypes
.Why?
It was necessary to go through the message structures starting from the root, but as it was before the PR, it only registered the root message.
Checklist
make ci-like-lint
) and all checks pass.make tests
) and all tests pass.Related PR(s)/Issue(s)
Closes #3160 issue.
backport from xk6-grpc PR