Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for registering nested message types #3178

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Conversation

thiagodpf
Copy link
Contributor

What?

client.load() (grpc module) was not registering protobuf nested messages in protoregistry.GlobalTypes.

Why?

It was necessary to go through the message structures starting from the root, but as it was before the PR, it only registered the root message.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make ci-like-lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

Closes #3160 issue.

backport from xk6-grpc PR

@CLAassistant
Copy link

CLAassistant commented Jul 8, 2023

CLA assistant check
All committers have signed the CLA.

mstoykov
mstoykov previously approved these changes Jul 8, 2023
olegbespalov
olegbespalov previously approved these changes Jul 9, 2023
Copy link
Contributor

@olegbespalov olegbespalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your contribution! 🚀

@olegbespalov olegbespalov added this to the v0.46.0 milestone Jul 9, 2023
@mstoykov mstoykov dismissed stale reviews from olegbespalov and themself via 2bbfc1c July 10, 2023 07:16
@codecov-commenter
Copy link

Codecov Report

Merging #3178 (aac34cd) into master (a2fe0a8) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

❗ Current head aac34cd differs from pull request most recent head 2bbfc1c. Consider uploading reports for the commit 2bbfc1c to get more accurate results

@@            Coverage Diff             @@
##           master    #3178      +/-   ##
==========================================
- Coverage   72.82%   72.76%   -0.07%     
==========================================
  Files         255      253       -2     
  Lines       19611    19611              
==========================================
- Hits        14281    14269      -12     
- Misses       4433     4441       +8     
- Partials      897      901       +4     
Flag Coverage Δ
ubuntu 72.76% <100.00%> (-0.01%) ⬇️
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
js/modules/k6/grpc/client.go 85.00% <100.00%> (+0.31%) ⬆️

... and 10 files with indirect coverage changes

@olegbespalov olegbespalov merged commit 9c019a4 into grafana:master Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grpc module is not registering protobuf nested messages
5 participants