Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudv2: Make sure to use the overwritten config #3195

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

codebien
Copy link
Contributor

It fixes the cloud v2 initialization that was using the passed client that doesn't consider the overwritten configuration. It now uses a new allocated and dedicated client based on the passed configuration that includes the overwritten fields.

@codebien codebien added the cloud label Jul 13, 2023
@codebien codebien added this to the v0.46.0 milestone Jul 13, 2023
@codebien codebien self-assigned this Jul 13, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3195 (0f4a683) into master (ac448b0) will decrease coverage by 0.15%.
The diff coverage is 100.00%.

❗ Current head 0f4a683 differs from pull request most recent head c864ce4. Consider uploading reports for the commit c864ce4 to get more accurate results

@@            Coverage Diff             @@
##           master    #3195      +/-   ##
==========================================
- Coverage   72.85%   72.70%   -0.15%     
==========================================
  Files         256      254       -2     
  Lines       19803    19802       -1     
==========================================
- Hits        14428    14398      -30     
- Misses       4474     4495      +21     
- Partials      901      909       +8     
Flag Coverage Δ
ubuntu ?
windows 72.70% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
output/cloud/output.go 75.33% <ø> (ø)
output/cloud/expv2/output.go 65.74% <100.00%> (+0.19%) ⬆️

... and 10 files with indirect coverage changes

@codebien codebien merged commit 1278f6e into master Jul 13, 2023
@codebien codebien deleted the fix-cloudv2-config-override branch July 13, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants