Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log packages lint fixes and test for loki flushing at end #3196

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

mstoykov
Copy link
Contributor

No description provided.

@mstoykov mstoykov added this to the v0.46.0 milestone Jul 13, 2023
@mstoykov
Copy link
Contributor Author

Those are the tests for #3194

@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2023

Codecov Report

Merging #3196 (78de93b) into master (1278f6e) will increase coverage by 0.48%.
The diff coverage is 57.21%.

❗ Current head 78de93b differs from pull request most recent head b8473c7. Consider uploading reports for the commit b8473c7 to get more accurate results

@@            Coverage Diff             @@
##           master    #3196      +/-   ##
==========================================
+ Coverage   72.69%   73.18%   +0.48%     
==========================================
  Files         254      259       +5     
  Lines       19802    19864      +62     
==========================================
+ Hits        14396    14538     +142     
+ Misses       4497     4403      -94     
- Partials      909      923      +14     
Flag Coverage Δ
ubuntu 73.13% <57.21%> (?)
windows 73.03% <57.21%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
metrics/engine/ingester.go 91.48% <ø> (ø)
output/cloud/expv2/collect.go 92.59% <ø> (+0.51%) ⬆️
output/cloud/expv2/flush.go 91.04% <ø> (-0.85%) ⬇️
output/cloud/v1/output.go 57.45% <0.00%> (-10.36%) ⬇️
output/cloud/expv2/output.go 72.83% <7.69%> (+7.09%) ⬆️
cloudapi/insights/client.go 62.20% <12.50%> (-17.18%) ⬇️
cmd/run.go 74.27% <86.66%> (+0.11%) ⬆️
output/cloud/insights/collect.go 91.48% <91.48%> (ø)
metrics/sink.go 97.40% <96.42%> (+1.51%) ⬆️
cloudapi/config.go 90.90% <100.00%> (ø)
... and 6 more

... and 11 files with indirect coverage changes

log/loki_test.go Outdated Show resolved Hide resolved
log/loki_test.go Show resolved Hide resolved
@mstoykov mstoykov merged commit 89d5b32 into master Jul 24, 2023
@mstoykov mstoykov deleted the lokiNotBeingWaitedToFlush branch July 24, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants