Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency of the demo GRPC server & gofumpt #3387

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

olegbespalov
Copy link
Contributor

@olegbespalov olegbespalov commented Oct 12, 2023

What?

Update the dependency of the demo GRPC server to address the dependency checker bot concerns. Also run the gofumpt -w . for the demo server.

Why?

To stop the noise.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make ci-like-lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

Closes #3384

@olegbespalov olegbespalov added this to the v0.48.0 milestone Oct 12, 2023
@olegbespalov olegbespalov mentioned this pull request Oct 12, 2023
48 tasks
@codebien
Copy link
Contributor

Can we use this PR for running gofumpt over the folder? I saw it has a small fix to apply.

@olegbespalov olegbespalov changed the title Update dependency of the demo GRPC server Update dependency of the demo GRPC server & gofumpt of it Oct 12, 2023
@olegbespalov olegbespalov changed the title Update dependency of the demo GRPC server & gofumpt of it Update dependency of the demo GRPC server & gofumpt Oct 12, 2023
@olegbespalov olegbespalov self-assigned this Oct 12, 2023
@olegbespalov olegbespalov merged commit f9d5ba0 into master Oct 12, 2023
20 checks passed
@olegbespalov olegbespalov deleted the maintance/grpc-demo-server branch October 12, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants