Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adressing linter issues for the api/v1 package #3463

Merged
merged 4 commits into from
Dec 7, 2023

Conversation

olegbespalov
Copy link
Contributor

@olegbespalov olegbespalov commented Nov 21, 2023

What?

This PR addresses the linter issue reported for an api/v1 package.

Why?

As we agreed we'd like to fix the existing issues for the master branch and this PR is part of that movement.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

Part of #769

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a087d42) 73.23% compared to head (977a2c0) 73.16%.
Report is 1 commits behind head on master.

❗ Current head 977a2c0 differs from pull request most recent head da50895. Consider uploading reports for the commit da50895 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3463      +/-   ##
==========================================
- Coverage   73.23%   73.16%   -0.07%     
==========================================
  Files         267      265       -2     
  Lines       20083    20081       -2     
==========================================
- Hits        14707    14693      -14     
- Misses       4463     4470       +7     
- Partials      913      918       +5     
Flag Coverage Δ
ubuntu 73.16% <100.00%> (+<0.01%) ⬆️
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@olegbespalov olegbespalov merged commit df41f01 into master Dec 7, 2023
22 checks passed
@olegbespalov olegbespalov deleted the chore/linter-api-v1 branch December 7, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants