-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving the experimental grpc module to the core #3490
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3490 +/- ##
==========================================
- Coverage 73.21% 72.40% -0.82%
==========================================
Files 267 274 +7
Lines 20083 20847 +764
==========================================
+ Hits 14704 15094 +390
- Misses 4465 4782 +317
- Partials 914 971 +57
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
9630653
to
890cd90
Compare
890cd90
to
d413bab
Compare
d413bab
to
f8fdddd
Compare
@@ -35,7 +34,7 @@ func getInternalJSModules() map[string]interface{} { | |||
"k6/experimental/redis": redis.New(), | |||
"k6/experimental/webcrypto": webcrypto.New(), | |||
"k6/experimental/websockets": &expws.RootModule{}, | |||
"k6/experimental/grpc": expGrpc.New(), | |||
"k6/experimental/grpc": grpc.NewExperimental(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It kind of makes more sense to me to move the warning logic to this file only so that the grpc parts are left only about the actual implementation.
Also will be easier to remove as you need to modify only here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 I assumed that this would be executed even if no module imports were in the script, no? 🤔 so it is either moving this logic to the module's resolver or...
On the other side, the clean up isn't hard and I even could sketch up a PR for a long term milestone for it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏🚀
What?
We are moving the experimental GRCP module to the core.
It is worth to review by commits, but in short:
Why?
The main feature of the experimental module (streaming) works as expected. We're ready to move forward.
Checklist
make lint
) and all checks pass.make tests
) and all tests pass.Related PR(s)/Issue(s)
Closes #3152