Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize k6/experimental/timers into k6/timers #3587

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Conversation

mstoykov
Copy link
Contributor

@mstoykov mstoykov commented Feb 9, 2024

What?

Stabilize k6/experimental/timers

Why?

SetTimeout and co. are basic tools needed to write most asynchronous code in javascript.

They are well known and used for years. As such having them in k6 is necessity.

They are currently under k6/timers and not available globally, but later PRs will likely also make them available globally while leaving the package versions as well and potentially adding other functions there.

see https://nodejs.org/api/timers.html or https://deno.land/std@0.110.0/node/timers.ts

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

closes #3297

@mstoykov mstoykov added the documentation-needed A PR which will need a separate PR for documentation label Feb 9, 2024
@mstoykov mstoykov added this to the v0.50.0 milestone Feb 9, 2024
@mstoykov mstoykov requested a review from a team as a code owner February 9, 2024 10:07
@mstoykov mstoykov requested review from olegbespalov and joanlopez and removed request for a team February 9, 2024 10:07
@mstoykov mstoykov merged commit e0f7c40 into master Feb 9, 2024
24 of 25 checks passed
@mstoykov mstoykov deleted the stabalizeTimers branch February 9, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation-needed A PR which will need a separate PR for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Making the k6/experimental/timers module part of the k6 core
3 participants