fix line numbers when inline sourcemap is used

[mstoykov]

What?

Fix sourcemaps when they are inlined.

Before that if there was an inline sourcemap we won't load it and go through the already used method of updating it.

This isn't a problem if babel actually transpiles it as it will load it, but in case the sourcecode was already transpiled with inline maps this will now update the lines correctly.

Why?

To have correct lines when people user sourcemaps .

Checklist

• I have performed a self-review of my code.
• I have added tests for my changes.
• I have run linter locally (make lint) and all checks pass.
• I have run tests locally (make tests) and all tests pass.
• I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

#3689

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 66.66667% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 73.28%. Comparing base (1b0088c) to head (d3c4f51).
Report is 3 commits behind head on master.

❗ Current head d3c4f51 differs from pull request most recent head 4a3ecee. Consider uploading reports for the commit 4a3ecee to get more accurate results

Files	Patch %	Lines
js/compiler/compiler.go	65.21%	4 Missing and 4 partials ⚠️
js/modules/resolution.go	33.33%	1 Missing and 1 partial ⚠️
js/modulestest/runtime.go	60.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3717      +/-   ##
==========================================
- Coverage   73.31%   73.28%   -0.03%     
==========================================
  Files         278      278              
  Lines       20425    20456      +31     
==========================================
+ Hits        14975    14992      +17     
- Misses       4499     4507       +8     
- Partials      951      957       +6     

Flag	Coverage Δ
ubuntu	73.20% <66.66%> (-0.03%)	⬇️
windows	73.14% <66.66%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[codebien]

It is not clear to me as a user, if I can fix it in some way. Do we have a suggestion? Or the answer is there isn't much you can do.

[mstoykov]

I would argue this warning is mostly so that when they report an issue - they report it with this warning

[szkiba]

In the case of the originally attached script, the line number has been corrected. At the same time, if I transfer the throw expression to another function, it no longer works.

interface User {
  name: string;
  id: number;
}

class UserAccount implements User {
  name: string;
  id: number;

  constructor(name: string) {
    this.name = name;
    this.id = Math.floor(Math.random() * Number.MAX_SAFE_INTEGER);
  }
}

function newUser(name: string): User {
  throw "other";
  return new UserAccount(name);
}

export { User, newUser };

[mstoykov]

@szkiba - I used the wrong base64 encoding, that doesn't support padding , and just so happened the original example works with it 😓 , but not this new one 🤦

I have now fixed it as well as fixing the warning message a bit

[szkiba]

It works now.

[codebien]

LGTM, just a small text suggestion

[szkiba]

LGTM