Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a minIterationDuration option #821

Merged
merged 3 commits into from
Nov 13, 2018
Merged

Add a minIterationDuration option #821

merged 3 commits into from
Nov 13, 2018

Conversation

na--
Copy link
Member

@na-- na-- commented Oct 23, 2018

This should fix #818, though I didn't have time to test it very much...

@codecov-io
Copy link

codecov-io commented Oct 23, 2018

Codecov Report

Merging #821 into master will increase coverage by 0.01%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #821      +/-   ##
==========================================
+ Coverage    69.9%   69.92%   +0.01%     
==========================================
  Files         111      111              
  Lines        8683     8691       +8     
==========================================
+ Hits         6070     6077       +7     
  Misses       2214     2214              
- Partials      399      400       +1
Impacted Files Coverage Δ
lib/options.go 92.5% <0%> (-1.18%) ⬇️
cmd/options.go 60.9% <100%> (+0.72%) ⬆️
js/runner.go 85.71% <100%> (+0.24%) ⬆️
core/engine.go 92.99% <0%> (ø) ⬆️
core/local/local.go 91.49% <0%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5788bee...4d8225d. Read the comment docs.

js/runner.go Outdated Show resolved Hide resolved
core/engine_test.go Outdated Show resolved Hide resolved
cmd/options.go Outdated Show resolved Hide resolved
@mstoykov
Copy link
Contributor

LGTM

@na-- na-- merged commit 86aa3f6 into master Nov 13, 2018
@na-- na-- deleted the min-iteration-duration branch November 13, 2018 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option for minimum iteration duration
3 participants