Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the cloud config option overwriting #848

Merged
merged 2 commits into from
Nov 23, 2018
Merged

Fix the cloud config option overwriting #848

merged 2 commits into from
Nov 23, 2018

Conversation

na--
Copy link
Member

@na-- na-- commented Nov 23, 2018

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #848 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #848      +/-   ##
==========================================
- Coverage      70%   69.98%   -0.03%     
==========================================
  Files         111      111              
  Lines        8705     8712       +7     
==========================================
+ Hits         6094     6097       +3     
- Misses       2214     2220       +6     
+ Partials      397      395       -2
Impacted Files Coverage Δ
stats/cloud/config.go 54.16% <ø> (+8.33%) ⬆️
stats/cloud/collector.go 67.14% <0%> (-2.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8e1c60...9d3a155. Read the comment docs.

@na-- na-- merged commit 87fb708 into master Nov 23, 2018
@na-- na-- deleted the cloud-config-fixes branch November 23, 2018 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants