From 7be2aec2d63dfea739abe0ef5fdb4fe7c1540ab0 Mon Sep 17 00:00:00 2001 From: Karsten Jeschkies Date: Fri, 20 Nov 2020 19:01:01 +0100 Subject: [PATCH] Fix linter issues. --- pkg/logentry/stages/multiline.go | 8 ++++---- pkg/logentry/stages/multiline_test.go | 11 +++++++---- 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/pkg/logentry/stages/multiline.go b/pkg/logentry/stages/multiline.go index 67a46a550f60..032af529ac9c 100644 --- a/pkg/logentry/stages/multiline.go +++ b/pkg/logentry/stages/multiline.go @@ -5,9 +5,9 @@ import ( "regexp" "time" + "github.com/go-kit/kit/log" "github.com/mitchellh/mapstructure" "github.com/pkg/errors" - "github.com/go-kit/kit/log" "github.com/prometheus/common/model" ) @@ -18,7 +18,7 @@ const ( const MultilineDropReason = "multiline collapse" -// MultilineConfig contains the configuration for a multilineStage +// MultilineConfig contains the configuration for a multilineStage type MultilineConfig struct { Expression *string `mapstructure:"firstline"` regex *regexp.Regexp @@ -33,7 +33,7 @@ func validateMultilineConfig(cfg *MultilineConfig) error { if err != nil { return errors.Errorf(ErrMultilineStageInvalidRegex, err) } - cfg.regex = expr + cfg.regex = expr return nil } @@ -90,4 +90,4 @@ func (m *multilineStage) Process(labels model.LabelSet, extracted map[string]int // Name implements Stage func (m *multilineStage) Name() string { return StageTypeMultiline -} \ No newline at end of file +} diff --git a/pkg/logentry/stages/multiline_test.go b/pkg/logentry/stages/multiline_test.go index f86e838278d4..3c6f16dbb9b5 100644 --- a/pkg/logentry/stages/multiline_test.go +++ b/pkg/logentry/stages/multiline_test.go @@ -10,6 +10,7 @@ import ( "github.com/stretchr/testify/require" ww "github.com/weaveworks/common/server" ) + func Test_multilineStage_Process(t *testing.T) { // Enable debug logging cfg := &ww.Config{} @@ -17,10 +18,12 @@ func Test_multilineStage_Process(t *testing.T) { util.InitLogger(cfg) Debug = true - mcfg := &MultilineConfig{Expression: ptrFromString("^START"),} - validateMultilineConfig(mcfg) + mcfg := &MultilineConfig{Expression: ptrFromString("^START")} + err := validateMultilineConfig(mcfg) + require.NoError(t, err) + stage := &multilineStage{ - cfg: mcfg, + cfg: mcfg, logger: util.Logger, buffer: new(bytes.Buffer), } @@ -37,4 +40,4 @@ func Test_multilineStage_Process(t *testing.T) { stage.Process(model.LabelSet{}, map[string]interface{}{}, ptrFromTime(time.Now()), &nextStart) require.Equal(t, "START line 2", nextStart) -} \ No newline at end of file +}