From 8daa694d12665148ba1ba18fa2da9d6f8fea1f20 Mon Sep 17 00:00:00 2001 From: Owen Diehl Date: Wed, 20 Jul 2022 15:57:58 +0800 Subject: [PATCH] [Fix] Furthers gcs latency buckets (#6721) * furthers gcs latency buckets Signed-off-by: Owen Diehl * adjusts bucket upper bound Signed-off-by: Owen Diehl --- pkg/storage/chunk/client/gcp/instrumentation.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/pkg/storage/chunk/client/gcp/instrumentation.go b/pkg/storage/chunk/client/gcp/instrumentation.go index c2d703fcbcdd..1522e27f038c 100644 --- a/pkg/storage/chunk/client/gcp/instrumentation.go +++ b/pkg/storage/chunk/client/gcp/instrumentation.go @@ -30,9 +30,8 @@ var ( Name: "gcs_request_duration_seconds", Help: "Time spent doing GCS requests.", - // GCS latency seems to range from a few ms to a few secs and is - // important. So use 6 buckets from 5ms to 5s. - Buckets: prometheus.ExponentialBuckets(0.005, 4, 6), + // 6 buckets from 5ms to 20s. + Buckets: prometheus.ExponentialBuckets(0.005, 4, 7), }, []string{"operation", "status_code"}) )