feat: add release please config #11333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Trivy scan found the following vulnerabilities:
|
kavirajk
reviewed
Nov 29, 2023
go.mod
Outdated
| @@ -1,6 +1,6 @@ | |||
| module github.com/grafana/loki | |||
|
|
|||
| go 1.20 | |||
| go 1.21 | |||
There was a problem hiding this comment.
wonder if this upgraded necessary for the integrating prepare-release?
Asking because, we may need to update the loki build image and few other places as well in that case.
There was a problem hiding this comment.
Please consider this PR waiting for some time now that bumps the directive too:
There was a problem hiding this comment.
@kavirajk our build does not work on 1.20. We have 1.21 in our build image. The new release process moves everything ti GitHub actions, and so we're relying on the go.mod file to setup go in the actions containers the build and tests are running in. Without this bump, the build fails.
trevorwhitney
force-pushed
the
prepare-release-please
branch
from
d716dd7
to
b30845e
Compare
trevorwhitney
added a commit
that referenced
this pull request
Jan 25, 2024
**What this PR does / why we need it**: The new release process is being developed in another repo for now as it enables much faster feedback loops. We are at the stage where we are pulling the Loki repo and building images, so it's time to move the `release-please` config into Loki, and configure it for the various packages we will be releasing. This PR adds the two basic configs that `release-please` requires. This PR does not change anything about the release process, it just enables us to keep iterating out of band until we're ready to move over. **Which issue(s) this PR fixes**: Re #11332
trevorwhitney
added a commit
that referenced
this pull request
Jan 25, 2024
trevorwhitney
added a commit
that referenced
this pull request
Jan 25, 2024
trevorwhitney
added a commit
that referenced
this pull request
Jan 26, 2024
**What this PR does / why we need it**: The new release process is being developed in another repo for now as it enables much faster feedback loops. We are at the stage where we are pulling the Loki repo and building images, so it's time to move the `release-please` config into Loki, and configure it for the various packages we will be releasing. This PR adds the two basic configs that `release-please` requires. This PR does not change anything about the release process, it just enables us to keep iterating out of band until we're ready to move over. This was already added to `main`, but adding here so I can test it on the release branch **Which issue(s) this PR fixes**: Re #11332
Gordejj
pushed a commit
to Gordejj/loki
that referenced
this pull request
Jan 29, 2024
**What this PR does / why we need it**: The new release process is being developed in another repo for now as it enables much faster feedback loops. We are at the stage where we are pulling the Loki repo and building images, so it's time to move the `release-please` config into Loki, and configure it for the various packages we will be releasing. This PR adds the two basic configs that `release-please` requires. This PR does not change anything about the release process, it just enables us to keep iterating out of band until we're ready to move over. **Which issue(s) this PR fixes**: Re grafana#11332
Gordejj
pushed a commit
to Gordejj/loki
that referenced
this pull request
Jan 29, 2024
**What this PR does / why we need it**: I did not intend to merge this change, reverting to what it was before merging grafana#11333
This was referenced Feb 28, 2024
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
**What this PR does / why we need it**: The new release process is being developed in another repo for now as it enables much faster feedback loops. We are at the stage where we are pulling the Loki repo and building images, so it's time to move the `release-please` config into Loki, and configure it for the various packages we will be releasing. This PR adds the two basic configs that `release-please` requires. This PR does not change anything about the release process, it just enables us to keep iterating out of band until we're ready to move over. **Which issue(s) this PR fixes**: Re grafana#11332
rhnasc
pushed a commit
to inloco/loki
that referenced
this pull request
Apr 12, 2024
**What this PR does / why we need it**: I did not intend to merge this change, reverting to what it was before merging grafana#11333
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The new release process is being developed in another repo for now as it enables much faster feedback loops. We are at the stage where we are pulling the Loki repo and building images, so it's time to move the
release-pleaseconfig into Loki, and configure it for the various packages we will be releasing.This PR adds the two basic configs that
release-pleaserequires. This PR does not change anything about the release process, it just enables us to keep iterating out of band until we're ready to move over.Which issue(s) this PR fixes:
Re #11332