feat: add release please config (#11333) #11789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What this PR does / why we need it**: The new release process is being developed in another repo for now as it enables much faster feedback loops. We are at the stage where we are pulling the Loki repo and building images, so it's time to move the `release-please` config into Loki, and configure it for the various packages we will be releasing. This PR adds the two basic configs that `release-please` requires. This PR does not change anything about the release process, it just enables us to keep iterating out of band until we're ready to move over. **Which issue(s) this PR fixes**: Re #11332
paul1r
approved these changes
Jan 25, 2024
This reverts commit d60f23e.
MichelHollands
approved these changes
Jan 26, 2024
| dist: clean | ||
| ifeq ($(SKIP_ARM),true) |
There was a problem hiding this comment.
(nit) The name SKIP_ARM is a bit misleading. You're swapping arm for Intel here.
There was a problem hiding this comment.
intel is being built in either case, so the guard is to whether only to build intel, or whether to build intel and arm, unless I'm missing something? problem is GitHub actions don't support arm yet, so we need a way to disable those archs specifically
trevorwhitney
added a commit
that referenced
this pull request
Jan 26, 2024
**What this PR does / why we need it**: Fixes a typo in #11789
This was referenced Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The new release process is being developed in another repo for now as it enables much faster feedback loops. We are at the stage where we are pulling the Loki repo and building images, so it's time to move the
release-pleaseconfig into Loki, and configure it for the various packages we will be releasing.This PR adds the two basic configs that
release-pleaserequires. This PR does not change anything about the release process, it just enables us to keep iterating out of band until we're ready to move over.This was already added to
main, but adding here so I can test it on the release branchWhich issue(s) this PR fixes:
Re #11332