Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long label name queries returns duplicate value #1220

Closed
cyriltovena opened this issue Oct 31, 2019 · 2 comments · Fixed by #1280
Closed

Long label name queries returns duplicate value #1220

cyriltovena opened this issue Oct 31, 2019 · 2 comments · Fixed by #1280
Labels
component/loki keepalive An issue or PR that will be kept alive and never marked as stale. type/bug Somehing is not working as expected

Comments

@cyriltovena
Copy link
Contributor

image

There must be a bug somewhere in the new schema.

@cyriltovena cyriltovena added kind/bug component/loki keepalive An issue or PR that will be kept alive and never marked as stale. labels Oct 31, 2019
@aocenas
Copy link
Member

aocenas commented Oct 31, 2019

This is the response from Loki seen by Grafana:

{"values":["__name__","app","ceph_daemon_id","ceph_osd_id","cluster","color","component","container_name","controller_revision_hash","controller_uid","diff_name","diff_namespace","diff_type","diff_verb","etcd_cluster","etcd_node","filename","hosted_metrics","instance","job","job_name","k8s_app","level","mgr","mon","mon_cluster","name","namespace","nodename","org","partitions","partitions_group","plan","pod_template_generation","pod_template_hash","product","redis_role","replica","restart","revision","rgw","role","rook_cluster","rook_object_store","statefulset_kubernetes_io_pod_name","stream","syslog_identifier","systemd_unit","test","tier","__name__","app","ceph_daemon_id","ceph_osd_id","cluster","color","component","container_name","controller_revision_hash","controller_uid","diff_name","diff_namespace","diff_type","diff_verb","etcd_cluster","etcd_node","filename","hosted_metrics","instance","jaeger_infra","job","job_name","k8s_app","level","mgr","mon","mon_cluster","name","namespace","nodename","org","partitions","partitions_group","plan","pod_template_generation","pod_template_hash","product","redis_role","replica","restart","revision","rgw","role","rook_cluster","rook_object_store","statefulset_kubernetes_io_pod_name","stream","syslog_identifier","systemd_unit","test","tier","version"]}

So seems the duplicated labels come from Loki and we do not do any deduplication later on.

@cyriltovena
Copy link
Contributor Author

This is from cortex with the composite store. I'll send a PR there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/loki keepalive An issue or PR that will be kept alive and never marked as stale. type/bug Somehing is not working as expected
Projects
None yet
3 participants