Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update google.golang.org/protobuf to v1.33.0 #12269

Merged
merged 2 commits into from
Mar 20, 2024
Merged

fix: update google.golang.org/protobuf to v1.33.0 #12269

merged 2 commits into from
Mar 20, 2024

Conversation

MichelHollands
Copy link
Contributor

@MichelHollands MichelHollands commented Mar 20, 2024 •
edited
Loading

What this PR does / why we need it:

CVE-2024-24786 requires an update of the google.golang.org/protobuf module to v1.33.0 .

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@MichelHollands
Update google.golang.org/protobuf to v1.33.0
45ad086 
Signed-off-by: Michel Hollands <michel.hollands@gmail.com>
@MichelHollands MichelHollands requested a review from a team as a code owner March 20, 2024 09:38
@MichelHollands MichelHollands changed the title Update google.golang.org/protobuf to v1.33.0 fix: update google.golang.org/protobuf to v1.33.0 Mar 20, 2024
@MichelHollands
Add vendor files
0ac5217 
Signed-off-by: Michel Hollands <michel.hollands@gmail.com>
@MichelHollands MichelHollands merged commit a6d1e7b into main Mar 20, 2024
14 checks passed
@MichelHollands MichelHollands deleted the update_protobuf_version branch March 20, 2024 10:05
MichelHollands added a commit that referenced this pull request Mar 21, 2024
@MichelHollands
fix: update google.golang.org/protobuf to v1.33.0 (#12269)
d14a8d7 
Signed-off-by: Michel Hollands <michel.hollands@gmail.com>
MichelHollands added a commit that referenced this pull request Mar 21, 2024
@MichelHollands
fix: update google.golang.org/protobuf to v1.33.0 (#12269) (#12287)
3186520 
Signed-off-by: Michel Hollands <michel.hollands@gmail.com>
@loki-gh-app loki-gh-app bot mentioned this pull request Mar 21, 2024
Merged
edsoncelio pushed a commit to edsoncelio/loki that referenced this pull request Mar 22, 2024
@MichelHollands @edsoncelio
fix: update google.golang.org/protobuf to v1.33.0 (grafana#12269)
0bd2afc 
Signed-off-by: Michel Hollands <michel.hollands@gmail.com>
@MichelHollands MichelHollands mentioned this pull request Mar 22, 2024
Merged
@loki-gh-app loki-gh-app bot mentioned this pull request Mar 27, 2024
Closed
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
@MichelHollands @rhnasc
fix: update google.golang.org/protobuf to v1.33.0 (grafana#12269)
7461332 
Signed-off-by: Michel Hollands <michel.hollands@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwanthgoli ashwanthgoli ashwanthgoli approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichelHollands @ashwanthgoli