Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve syntax parser for pattern #12489

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

cyriltovena
Copy link
Contributor

What this PR does / why we need it:

Thought we had an issue there, but not really, although we still useful to get 35% less alloc.

❯ benchstat before.txt after.txt
name          old time/op    new time/op    delta
ParseExpr-16    8.73µs ± 3%    7.79µs ± 1%  -10.81%  (p=0.008 n=5+5)

name          old alloc/op   new alloc/op   delta
ParseExpr-16    5.07kB ± 0%    3.28kB ± 0%  -35.27%  (p=0.008 n=5+5)

name          old allocs/op  new allocs/op  delta
ParseExpr-16      26.0 ± 0%      25.0 ± 0%   -3.85%  (p=0.008 n=5+5)

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@cyriltovena cyriltovena requested a review from a team as a code owner April 5, 2024 14:29
@cyriltovena
Copy link
Contributor Author

Let's merge after 3.0 don't think it will make a big difference for the release.

@cyriltovena cyriltovena merged commit 48dae44 into grafana:main Apr 11, 2024
11 checks passed
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants