-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix indentation of query range values in helm #12577
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your contribution ❤️
could you please run make -C docs sources/setup/install/helm/reference.md
and commit doc changes?
@coro I'm sorry, GH notifications are horrible and I didn't notice you had updated the PR, my bad. Could you do it one more time? |
55f2d9c
to
9bf6b40
Compare
@DylanGuedes Here you. go, rebased and made it into |
@DylanGuedes I've again rebased onto |
@coro Currently every PR increments the Helm version, but we're considering changing to weekly Helm updates and will be discussing that in this week's Community Call |
That sounds like a positive change to me. I've rebased again onto |
Is there a timeline on this one line... preventing upgrades... @DylanGuedes @JStickler |
@coro, apologies, I thought I could just update the version number and merge this, but instead I introduced merge conflicts. =( |
00c32ae
to
d10ee17
Compare
@JStickler I've rebased again. I believe there was nothing else you wanted changing, but let me know otherwise / feel free to change. |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes issues mentioned in #12506 (comment)
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR