Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add a missing continue in fuse which may cause incorrect bloom test result #12650

Merged
merged 1 commit into from
Apr 17, 2024
Merged

fix: Add a missing continue in fuse which may cause incorrect bloom test result #12650

merged 1 commit into from
Apr 17, 2024

Conversation

honganan
Copy link
Contributor

@honganan honganan commented Apr 17, 2024 •
edited
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #12649

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@honganan honganan requested a review from a team as a code owner April 17, 2024 09:22
@owen-d
Copy link
Member

owen-d commented Apr 17, 2024

Thanks, and nice catch 👍

@owen-d owen-d merged commit 0d1ebeb into grafana:main Apr 17, 2024
14 checks passed
@honganan honganan deleted the fix-bloom-fuse branch April 17, 2024 22:57
This was referenced Apr 22, 2024
Closed
Closed
This was referenced May 6, 2024
Closed
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request May 20, 2024
Closed
This was referenced May 27, 2024
Closed
Closed
This was referenced Jun 10, 2024
Closed
Merged
@loki-gh-app loki-gh-app bot mentioned this pull request Jun 24, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 1, 2024
Closed
@grafanabot grafanabot mentioned this pull request Jul 2, 2024
Open
This was referenced Jul 3, 2024
Closed
Closed
Closed
@RodrigoCMoraes RodrigoCMoraes mentioned this pull request Jul 12, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 15, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 22, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Oct 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owen-d owen-d owen-d approved these changes

Assignees
No one assigned
Labels
feature/blooms size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bloom]continue lost in fuse that may cause incorrect bloom test result
3 participants
@honganan @owen-d @JStickler