Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ksonnet): Do not generate rbac for consul if you are using memberlist #12688

Merged
merged 5 commits into from
Apr 26, 2024

Conversation

sentoz
Copy link
Contributor

@sentoz sentoz commented Apr 19, 2024

What this PR does / why we need it:

Added a condition that disables rbac creation for consul if memberlist is used

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Title matches the required conventional commits format, see here

@sentoz sentoz requested a review from a team as a code owner April 19, 2024 09:10
@sentoz sentoz changed the title Loki ksonnet: Do not generate rbac for consul if you are using memberlist fix(ksonnet): Do not generate rbac for consul if you are using memberlist Apr 19, 2024
@sentoz
Copy link
Contributor Author

sentoz commented Apr 19, 2024

Friends, I would like to consider the issue of adopting this change.
@chaudum @ashwanthgoli

Copy link
Contributor

@cstyan cstyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like a reasonable change 👍 since we haven't used consul ourselves in quite some time I didn't know what the sidekick was, but I see that the container itself is created by the consul_deployment so the rbac object got missed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants