-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ksonnet): Do not generate rbac for consul if you are using memberlist #12688
Conversation
Friends, I would like to consider the issue of adopting this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like a reasonable change 👍 since we haven't used consul ourselves in quite some time I didn't know what the sidekick was, but I see that the container itself is created by the consul_deployment
so the rbac object got missed
What this PR does / why we need it:
Added a condition that disables rbac creation for consul if memberlist is used
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)