Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(blooms): Deduplicate filtered series and chunks #12791

Merged
merged 4 commits into from
Apr 25, 2024
Merged

fix(blooms): Deduplicate filtered series and chunks #12791

merged 4 commits into from
Apr 25, 2024

Conversation

chaudum
Copy link
Contributor

@chaudum chaudum commented Apr 25, 2024

What this PR does / why we need it:

Blocks may have overlapping fingerprint ranges, therefore one an the same series can assigned to different bloom blocks and executed on different bloom gateways. This then results in the same series and their chunks to be present multiple times in the response.
Therefore, series and their chunks need to be de-duplicated upon merge before returning them to the caller.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

chaudum added 4 commits April 25, 2024 11:29
@chaudum
Use named arguments in BlockResolver interface
73925c9 
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
@chaudum
Remove excessive logging in bloomgateway client
5582d4e 
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
@chaudum
Dedupe series and chunks when merging respones from filter requests
08b4dc9 
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
@chaudum
Use deduping merge function when merging results cache responses
13a74ab 
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
@chaudum chaudum requested a review from a team as a code owner April 25, 2024 14:03
@grafanabot
Copy link
Collaborator

This PR must be merged before a backport PR will be created.

1 similar comment
@grafanabot
Copy link
Collaborator

This PR must be merged before a backport PR will be created.

@owen-d owen-d merged commit 3bf2d1f into main Apr 25, 2024
61 checks passed
@owen-d owen-d deleted the chaudum/dedupe-filtered-chunks branch April 25, 2024 16:11
grafanabot pushed a commit that referenced this pull request Apr 25, 2024
@chaudum @grafana-delivery-bot
fix(blooms): Deduplicate filtered series and chunks (#12791)
955d4f8 
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
(cherry picked from commit 3bf2d1f)
@grafanabot grafanabot mentioned this pull request Apr 25, 2024
Merged
7 tasks
chaudum added a commit that referenced this pull request Apr 25, 2024
@grafanabot @chaudum
chore: [k199] fix(blooms): Deduplicate filtered series and chunks (#1…
22a8825 
…2794)

Backport 3bf2d1f from #12791

Co-authored-by: Christian Haudum <christian.haudum@gmail.com>
@loki-gh-app loki-gh-app bot mentioned this pull request Apr 29, 2024
Closed
This was referenced May 6, 2024
Closed
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request May 20, 2024
Closed
This was referenced May 27, 2024
Closed
Closed
This was referenced Jun 10, 2024
Closed
Merged
@loki-gh-app loki-gh-app bot mentioned this pull request Jun 24, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 1, 2024
Closed
@grafanabot grafanabot mentioned this pull request Jul 2, 2024
Open
This was referenced Jul 3, 2024
Closed
Closed
Closed
@RodrigoCMoraes RodrigoCMoraes mentioned this pull request Jul 12, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 15, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 22, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Oct 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owen-d owen-d owen-d approved these changes

Assignees
No one assigned
Labels
backport k199 product-approved size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chaudum @grafanabot @owen-d