Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unused parameter causing lint error #12801

Merged
merged 2 commits into from
Apr 26, 2024
Merged

fix: remove unused parameter causing lint error #12801

merged 2 commits into from
Apr 26, 2024

Conversation

MichelHollands
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@MichelHollands
Fix lint error
d2ecea7 
Signed-off-by: Michel Hollands <michel.hollands@gmail.com>
@MichelHollands
Fix typo
6764042 
Signed-off-by: Michel Hollands <michel.hollands@gmail.com>
@MichelHollands MichelHollands changed the title Fix lint error Fix: remove unused parameter causing lint error Apr 26, 2024
@MichelHollands MichelHollands changed the title Fix: remove unused parameter causing lint error fix: remove unused parameter causing lint error Apr 26, 2024
@MichelHollands MichelHollands marked this pull request as ready for review April 26, 2024 09:58
@MichelHollands MichelHollands requested a review from a team as a code owner April 26, 2024 09:58
@MichelHollands MichelHollands merged commit 33e82ec into main Apr 26, 2024
59 checks passed
@MichelHollands MichelHollands deleted the fix_linter_issue branch April 26, 2024 12:05
@loki-gh-app loki-gh-app bot mentioned this pull request Apr 29, 2024
Closed
This was referenced May 6, 2024
Closed
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request May 20, 2024
Closed
This was referenced May 27, 2024
Closed
Closed
This was referenced Jun 10, 2024
Closed
Merged
@loki-gh-app loki-gh-app bot mentioned this pull request Jun 24, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 1, 2024
Closed
@grafanabot grafanabot mentioned this pull request Jul 2, 2024
Open
This was referenced Jul 3, 2024
Closed
Closed
Closed
@RodrigoCMoraes RodrigoCMoraes mentioned this pull request Jul 12, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 15, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 22, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Oct 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyzannur poyzannur poyzannur approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichelHollands @poyzannur