-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(blooms): Blooms/v2 encoding multipart series #13093
Merged
owen-d
merged 39 commits into
grafana:main
from
owen-d:blooms/v2-encoding-multipart-series
Jun 6, 2024
Merged
feat(blooms): Blooms/v2 encoding multipart series #13093
owen-d
merged 39 commits into
grafana:main
from
owen-d:blooms/v2-encoding-multipart-series
Jun 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
…m metrics Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
…uiting queries on each bloom Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
…multipart-series Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
owen-d
changed the title
Blooms/v2 encoding multipart series
feat(blooms): Blooms/v2 encoding multipart series
May 31, 2024
owen-d
force-pushed
the
blooms/v2-encoding-multipart-series
branch
from
May 31, 2024 21:41
cd49144
to
be6f549
Compare
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
salvacorts
reviewed
Jun 4, 2024
} | ||
|
||
func (b *BlockQuerierIter) Next() bool { | ||
return b.LazySeriesIter.Next() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I think we can remove this since the method will be inherited.
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
owen-d
force-pushed
the
blooms/v2-encoding-multipart-series
branch
from
June 4, 2024 18:59
4aa6e83
to
5c6d4ae
Compare
…multipart-series Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
owen-d
force-pushed
the
blooms/v2-encoding-multipart-series
branch
from
June 4, 2024 19:57
9c263fb
to
b682a8c
Compare
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
chaudum
reviewed
Jun 6, 2024
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
slim-bean
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Jun 10, 2024
This was referenced Jul 3, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V2 bloom format supporting multipart blooms
A lot of refactoring in here in the pursuit of multipart blooms. We've found that blooms for certain series can easily create blooms that are too large to reasonably handle. This hurts in a few ways:
We initially addressed this with the stopgap #12796 which abandoned bloom creation once we hit a configurable size. This helped stabilized our read & write paths, but we stopped ingesting a lot of data into the blooms themselves.
This PR introduces a new
V2
version for bloom blocks which encodes large blooms into multiple sections in order to make memory usage less volatile on both read & write paths by making the size of any particular bloom more manageable & consistent.I'll be testing this out on some of our clusters shortly.
/cc @honganan for awareness -- this adds a new v2 version to the bloom blocks binary format.