fix: Do not filter out chunks for store when From==Through and From==start
#13117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
chaudum
changed the title
From ==Through and From == start From==Through and From==start
slim-bean
reviewed
Jun 4, 2024
Co-authored-by: Ed Welch <edward.welch@grafana.com>
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
|
This PR must be merged before a backport PR will be created. |
DylanGuedes
reviewed
Jun 4, 2024
grafanabot
pushed a commit
that referenced
this pull request
Jun 4, 2024
…m==start` (#13117) This PR fixes a bug where chunks are incorrectly filtered out when their `From` timestamp is equal to their `Through` timestamp (which happens when there is a single log line) and the `From` timestamp is equal to the `from` time of the of the request. How to reproduce: 1. Insert a single log line with a timestamp exactly at point of an hour 2. Flush ingester 3. Query log line with a split interval of 1h Signed-off-by: Christian Haudum <christian.haudum@gmail.com> Co-authored-by: Ed Welch <edward.welch@grafana.com> (cherry picked from commit d9cc513)
Merged
7 tasks
chaudum
added a commit
that referenced
this pull request
Jun 4, 2024
…ough` and `From==start` (#13121) Backport d9cc513 from #13117 This PR fixes a bug where chunks are incorrectly filtered out when their From timestamp is equal to their Through timestamp (which happens when there is a single log line) and the From timestamp is equal to the from time of the of the request. How to reproduce: * Insert a single log line with a timestamp exactly at point of an hour * Flush ingester * Query log line with a split interval of 1h Co-authored-by: Christian Haudum <christian.haudum@gmail.com>
This was referenced Jun 10, 2024
This was referenced Jul 3, 2024
7 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes a bug where chunks are incorrectly filtered out when their
Fromtimestamp is equal to theirThroughtimestamp (which happens when there is a single log line) and theFromtimestamp is equal to thefromtime of the of the request.How to reproduce:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Fromis inclusive and theThroughis exclusiveFromandThroughare inclusive, becauseThroughrepresents the timestamp of the last log line in the chunk.Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR