Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Tune Patterns query drain instance #13137

Merged
merged 2 commits into from
Jun 5, 2024
Merged

feat: Tune Patterns query drain instance #13137

merged 2 commits into from
Jun 5, 2024

Conversation

benclive
Copy link
Contributor

@benclive benclive commented Jun 5, 2024

What this PR does / why we need it:

  • Tunes the Patterns API Query Drain instance by setting SimTh to 1.0. This has the effect of merging & deduplicating patterns across streams without changing them or inserting more placeholder tokens which lead to very generic patterns.
  • Adds metrics to see how many patterns are being returned & discarded by this Query Drain
    • I'm expecting the number of discarded patterns to be far higher than the number of retained patterns on each query.

@benclive benclive requested a review from a team as a code owner June 5, 2024 10:02
@benclive benclive requested a review from cyriltovena June 5, 2024 10:02
cyriltovena
cyriltovena approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 30df31e into main Jun 5, 2024
60 checks passed
@cyriltovena cyriltovena deleted the tune-query-drain branch June 5, 2024 12:51
This was referenced Jun 10, 2024
Closed
Merged
@loki-gh-app loki-gh-app bot mentioned this pull request Jun 24, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 1, 2024
Closed
@grafanabot grafanabot mentioned this pull request Jul 2, 2024
Open
This was referenced Jul 3, 2024
Closed
Closed
Closed
@RodrigoCMoraes RodrigoCMoraes mentioned this pull request Jul 12, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 15, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 22, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Oct 18, 2024
Open
@loki-gh-app loki-gh-app bot mentioned this pull request Dec 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benclive @cyriltovena