fix: Add copyString function to symbolizer to avoid retaining memory #13146
+2
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This was reported by the community that when using structured metadata ingester were leaking memory.
Labels have a special proto Unmarshaller to avoid string copy since it was never interned before it was never causing a problem. But since the addition of structured metadata we now do intern thoses labels and they hold reference of the full GRPC buffer from the push request.
https://github.com/grafana/loki/blob/main/vendor/github.com/grafana/loki/pkg/push/types.go#L667
To fix the issue I simply copy the string before interning it. We could consider removing this optimisation too, but I'm afraid it will have other impact so going safe for now.
Which issue(s) this PR fixes:
Fixes #13123
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR