fix: Correctly encode step when translating proto to http internally #13171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benclive
commented
Jun 7, 2024
| } | ||
|
|
||
| if request.Step != 0 { | ||
| params["step"] = []string{fmt.Sprintf("%f", float64(request.Step)/float64(1e3))} |
There was a problem hiding this comment.
An alternative is to format the step as a duration string so 3000 becomes 3000ms instead of 3.000 seconds.
| @@ -202,6 +202,57 @@ func Test_codec_EncodeDecodeRequest(t *testing.T) { | |||
| Step: 30 * 1e3, // step is expected in ms; default is 0 or no step | |||
| AggregateBy: "series", | |||
| }, false}, | |||
| {"detected_fields", func() (*http.Request, error) { | |||
| return DefaultCodec.EncodeRequest(ctx, &DetectedFieldsRequest{ | |||
There was a problem hiding this comment.
I'm a bit confused as to why we use a wrapped queryrange.DetectedFieldsRequest and not the raw logproto.DetectedFieldsRequest here - is this the right thing to do?
There was a problem hiding this comment.
the query-frontend is messy for sure I think it's fine.
| return DefaultCodec.EncodeRequest(ctx, &DetectedFieldsRequest{ | ||
| logproto.DetectedFieldsRequest{ | ||
| Query: `{foo="bar"}`, | ||
| Start: start, |
There was a problem hiding this comment.
Other proto api objects use unix nanos for time, but these 3 (DetectedFields/DetectedLabels/QueryPatterns) use google.protobuf.Timestamp instead. Is there a reason for that? Should we be consistent across all our APIs and use one or the other?
This was referenced Jun 10, 2024
This was referenced Jul 3, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes the encoding from a proto to a http request for QueryPatterns & DetectedFields & DetectedLabels
frontend: protobufso it was tough to reproduce locally. With protobuf encoding, everything worked as expected.Fixes #13155