fix: separates directory creation from permission checks #13248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes grafana#13222 Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
slim-bean
approved these changes
Jun 17, 2024
grafanabot
pushed a commit
that referenced
this pull request
Jun 18, 2024
(cherry picked from commit 1086783)
This was referenced Jul 8, 2024
This was referenced Aug 15, 2024
This was referenced Oct 14, 2024
This was referenced Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #13222
Signed-off-by: Owen Diehl ow.diehl@gmail.com
The change from https://github.com/grafana/loki/pull/12019/files cascaded into other usage of
EnsureDirectoryand thus required every place it was called to require at least0o700permissions, effectively breaking any read-only mounts.I've separated creation from permissions testing so they can be applied independently, added some more utilities, and some testware.