-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(helm): Make gateway container port configurable. #13294
Conversation
Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
@@ -62,7 +62,7 @@ spec: | |||
imagePullPolicy: {{ .Values.gateway.image.pullPolicy }} | |||
ports: | |||
- name: http-metrics | |||
containerPort: 8080 | |||
containerPort: {{ .Values.gateway.containerPort }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember something that numbers in YAML may be rendered with scientific notation, e.g. 8.08e3
... does this work with K8s?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind, I think this was related to something else (printf
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not aware of that. Will check it in local and confirm before merging. Thanks for the heads up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
template rending just fine (custom port 8081)
helm template loki ./ --values distributed-values.yaml | rg nginx -A 4
- name: nginx
image: docker.io/nginxinc/nginx-unprivileged:1.24-alpine
imagePullPolicy: IfNotPresent
ports:
- name: http-metrics
containerPort: 8081
Also rendering default without any overrides.
- name: nginx
image: docker.io/nginxinc/nginx-unprivileged:1.24-alpine
imagePullPolicy: IfNotPresent
ports:
- name: http-metrics
containerPort: 8080
Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
What this PR does / why we need it:
Avoid gateway container port being hard-coded and make it configurable. Default is still
8080
(previously hard-coded value).Which issue(s) this PR fixes:
Fixes NA
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR