Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blooms): Delete outdated metas during planning #13363

Merged

Conversation

salvacorts
Copy link
Contributor

@salvacorts salvacorts commented Jul 1, 2024

What this PR does / why we need it:
If a planner crashes before receiving all tasks for a given tenant-table combination, it will not delete the outdated metas and blocks. This PR fixes this by also deleting outdated metas during the planning phase. Thereafter, gaps will be computed only with the metas that are up to date.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@salvacorts salvacorts marked this pull request as ready for review July 1, 2024 14:14
@salvacorts salvacorts requested a review from a team as a code owner July 1, 2024 14:14
return 0, fmt.Errorf("failed to delete outdated metas: %w", err)
}

return tasksSucceed, nil
}

func (p *Planner) deleteOutdatedMetasAndBlocks(
func (p *Planner) deleteOutdatedMetas(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: The function name is slightly misleading. Maybe add a comment what the function does and what it returns.

@salvacorts salvacorts merged commit 11e1976 into main Jul 3, 2024
60 checks passed
@salvacorts salvacorts deleted the salvacorts/bloom-refactor/delete-outdated-during-planning branch July 3, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants