Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(blooms): ensure tokenizer cache is reset between series #13370

Merged
merged 2 commits into from
Jul 1, 2024
Merged

fix(blooms): ensure tokenizer cache is reset between series #13370

merged 2 commits into from
Jul 1, 2024

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Jul 1, 2024

Fixes bug where ngrams were not added to blooms b/c they had been added previously to a potentially different series. This caused blooms to fail membership tests incorrectly.

@owen-d owen-d requested a review from a team as a code owner July 1, 2024 20:19
cyriltovena
cyriltovena approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@owen-d
fix(blooms): ensure tokenizer cache is reset between series
c5e3bc8 
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
@owen-d
bloom tokenizer cache reset test
f95eab1 
Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
@owen-d owen-d force-pushed the blooms/reset-tokenizer-cache-between-series branch from 94fa5fc to f95eab1 Compare July 1, 2024 23:02
@owen-d owen-d merged commit 04bc3a4 into grafana:main Jul 1, 2024
60 checks passed
@chaudum chaudum added type/bug Somehing is not working as expected backport k209 labels Jul 2, 2024
grafanabot pushed a commit that referenced this pull request Jul 2, 2024
@owen-d @grafana-delivery-bot
fix(blooms): ensure tokenizer cache is reset between series (#13370)
751c4ef 
(cherry picked from commit 04bc3a4)
@grafanabot grafanabot mentioned this pull request Jul 2, 2024
Merged
chaudum pushed a commit that referenced this pull request Jul 2, 2024
@grafanabot @owen-d
chore: [k209] fix(blooms): ensure tokenizer cache is reset between se…
d05e91b 
…ries (#13371)

Backport 04bc3a4 from #13370

---

Fixes bug where ngrams were not added to blooms b/c they had been added previously to a potentially different series. This caused blooms to fail membership tests incorrectly.

Co-authored-by: Owen Diehl <ow.diehl@gmail.com>
grafanabot pushed a commit that referenced this pull request Jul 2, 2024
@owen-d @grafana-delivery-bot
fix(blooms): ensure tokenizer cache is reset between series (#13370)
95a05f4 
(cherry picked from commit 04bc3a4)
grafanabot pushed a commit that referenced this pull request Jul 2, 2024
@owen-d @grafana-delivery-bot
fix(blooms): ensure tokenizer cache is reset between series (#13370)
1f59343 
(cherry picked from commit 04bc3a4)
This was referenced Jul 2, 2024
Merged
Merged
chaudum pushed a commit that referenced this pull request Jul 2, 2024
@grafanabot @owen-d
chore: [k208] fix(blooms): ensure tokenizer cache is reset between se…
ea616b6 
…ries (#13374)

Backport 04bc3a4 from #13370

---

Fixes bug where ngrams were not added to blooms b/c they had been added previously to a potentially different series. This caused blooms to fail membership tests incorrectly.

Co-authored-by: Owen Diehl <ow.diehl@gmail.com>
chaudum pushed a commit that referenced this pull request Jul 2, 2024
@grafanabot @owen-d
chore: [k207] fix(blooms): ensure tokenizer cache is reset between se…
7116a80 
…ries (#13373)

Backport 04bc3a4 from #13370

---

Fixes bug where ngrams were not added to blooms b/c they had been added previously to a potentially different series. This caused blooms to fail membership tests incorrectly.

Co-authored-by: Owen Diehl <ow.diehl@gmail.com>
This was referenced Jul 8, 2024
Closed
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 15, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 22, 2024
Closed
This was referenced Aug 15, 2024
Open
Open
@loki-gh-app loki-gh-app bot mentioned this pull request Sep 9, 2024
Merged
@loki-gh-app loki-gh-app bot mentioned this pull request Sep 23, 2024
Open
@loki-gh-app loki-gh-app bot mentioned this pull request Sep 30, 2024
Open
@loki-gh-app loki-gh-app bot mentioned this pull request Oct 7, 2024
Open
This was referenced Oct 14, 2024
Open
Closed
This was referenced Oct 21, 2024
Open
Open
@loki-gh-app loki-gh-app bot mentioned this pull request Nov 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
backport k207 backport k208 backport k209 size/M type/bug Somehing is not working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@owen-d @cyriltovena @chaudum