Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(loki): Do not enforce max-query-bytes-read and max-querier-bytes-read in limited tripperware #13406

Merged

Conversation

salvacorts
Copy link
Contributor

@salvacorts salvacorts commented Jul 4, 2024

What this PR does / why we need it:
Limited queries without filters will not shard ands return as soon as 1k lines are read. Therefore, the likelyhood of loading too many chunks in memory while processing a query of this type is very low.

As a result, in order to improve the user experience, we have decided to remove the max-query-bytes-read and max-querier-bytes-read limits from the limited tripperware.

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Jul 4, 2024
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM seems fair to me.

@salvacorts salvacorts marked this pull request as ready for review July 4, 2024 08:48
@salvacorts salvacorts requested a review from a team as a code owner July 4, 2024 08:48
@salvacorts salvacorts merged commit 47f6ea5 into main Jul 4, 2024
61 checks passed
@salvacorts salvacorts deleted the salvacorts/remove-query-size-limits-limited-queries branch July 4, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants