Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blooms): skip empty blooms on reads #13500

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Jul 12, 2024

Read path safeguard to prevent filtering chunks associated with empty blooms while we work on finding the underlying cause of empty blooms in compaction.

Signed-off-by: Owen Diehl <ow.diehl@gmail.com>
@owen-d owen-d requested a review from a team as a code owner July 12, 2024 00:28
@chaudum chaudum merged commit bfa6955 into grafana:main Jul 12, 2024
61 checks passed
@salvacorts salvacorts mentioned this pull request Jul 12, 2024
7 tasks
@salvacorts salvacorts added backport k210 type/bug Somehing is not working as expected labels Jul 12, 2024
@grafanabot
Copy link
Collaborator

Hello @salvacorts!
Backport pull requests need to be either:

  • Pull requests which address bugs,
  • Urgent fixes which need product approval, in order to get merged,
  • Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If the pull request modifies CI behaviour, please add the type/ci label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

grafanabot pushed a commit that referenced this pull request Jul 12, 2024
Read path safeguard to prevent filtering chunks associated with empty blooms while we work on finding the underlying cause of empty blooms in compaction.

(cherry picked from commit bfa6955)
@salvacorts salvacorts mentioned this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport k210 size/M type/bug Somehing is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants