Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bootstrap metastore for wal segments #13550

Merged
merged 19 commits into from
Jul 19, 2024

Conversation

cyriltovena
Copy link
Contributor

What this PR does / why we need it:

This adds a new component metastore that is using raft for reliability and index the last 15m of wal segment ID.

This is very hacky and experimental to move forward with querying the wal segment without listing them all. This is going to change a lot over time.

TODO:

  • Needs to wire that up in the write path now.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Jul 17, 2024
@cyriltovena cyriltovena marked this pull request as ready for review July 17, 2024 11:11
@cyriltovena cyriltovena requested a review from a team as a code owner July 17, 2024 11:11
Copy link
Contributor

@grobinson-grafana grobinson-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me, however I didn't look at the metastore code in depth, just at the integration with ingester-rf1. If you would like a more in-depth review of the metastore code please ask!

pkg/ingester-rf1/flush.go Show resolved Hide resolved
pkg/storage/bloom/v1/bloom_tokenizer.go Outdated Show resolved Hide resolved
@cyriltovena cyriltovena merged commit 0b47498 into grafana:main Jul 19, 2024
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants