Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blooms): Use correct key to populate blockscache at startup #13624

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

chaudum
Copy link
Contributor

@chaudum chaudum commented Jul 23, 2024

What this PR does / why we need it:

The cache key for block directories in the blocks cache are the block's address without the directory prefix. This is how the directory is put to the LRU cache after downloading and extracting the block tarball.

This PR fixes the incorrect cache key used to populate the cache from disk on startup, which contained the file system directory prefix.

Since the cached item from startup is never used, it gets evicted first in case of a full cache, or due to its TTL. This causes also the underlying directory on disk to be deleted, which can however still be referenced from the correct cache key for that directory from a later download.
That caused the error getting index reader: opening series file: open /path/to/block/series: no such file or directory when trying to query the block, because the correct cache key was still present.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@chaudum chaudum requested a review from a team as a code owner July 23, 2024 10:09
The cache key for block directories in the blockscache are the block's
address without the directory prefix. This is how the directory is put
to the LRU cache after downloading and extracing the block tarball.

This PR fixes the incorrect cache key used to populate the cache from
disk on startup, which contained the filesystem directory prefix.

Since the cached item from startup is never used, it gets evicted first
in case of a full cache, or due to its TTL. This causes also the
underlying directory on disk to be deleted, which can however still be
referenced from the correct cache key for that directory from a later
download.
That caused the error "getting index reader: opening series file: open
/path/to/block/series: no such file or directory" when trying to query
the block, because the correct cache key was still present.

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
@chaudum chaudum force-pushed the chaudum/debug-blockscache branch from 87f1066 to 3d080b8 Compare July 23, 2024 10:14
@chaudum chaudum added type/bug Somehing is not working as expected backport k211 backport k212 labels Jul 23, 2024
@grafanabot
Copy link
Collaborator

This PR must be merged before a backport PR will be created.

2 similar comments
@grafanabot
Copy link
Collaborator

This PR must be merged before a backport PR will be created.

@grafanabot
Copy link
Collaborator

This PR must be merged before a backport PR will be created.

Copy link
Contributor

@salvacorts salvacorts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice catch! 👏

@chaudum chaudum merged commit 2624a4b into main Jul 23, 2024
64 checks passed
@chaudum chaudum deleted the chaudum/debug-blockscache branch July 23, 2024 10:24
grafanabot pushed a commit that referenced this pull request Jul 23, 2024
The cache key for block directories in the blocks cache are the block's address without the directory prefix. This is how the directory is put to the LRU cache after downloading and extracting the block tarball.

This PR fixes the incorrect cache key used to populate the cache from disk on startup, which contained the file system directory prefix.

Since the cached item from startup is never used, it gets evicted first in case of a full cache, or due to its TTL. This causes also the underlying directory on disk to be deleted, which can however still be referenced from the correct cache key for that directory from a later download.
That caused the error `getting index reader: opening series file: open /path/to/block/series: no such file or directory` when trying to query the block, because the correct cache key was still present.

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
(cherry picked from commit 2624a4b)
grafanabot pushed a commit that referenced this pull request Jul 23, 2024
The cache key for block directories in the blocks cache are the block's address without the directory prefix. This is how the directory is put to the LRU cache after downloading and extracting the block tarball.

This PR fixes the incorrect cache key used to populate the cache from disk on startup, which contained the file system directory prefix.

Since the cached item from startup is never used, it gets evicted first in case of a full cache, or due to its TTL. This causes also the underlying directory on disk to be deleted, which can however still be referenced from the correct cache key for that directory from a later download.
That caused the error `getting index reader: opening series file: open /path/to/block/series: no such file or directory` when trying to query the block, because the correct cache key was still present.

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
(cherry picked from commit 2624a4b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport k211 backport k212 size/XS type/bug Somehing is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants