-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: instrument failed chunk encoding/decoding #13684
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasslessParticle
approved these changes
Jul 26, 2024
This PR must be merged before a backport PR will be created. |
1 similar comment
This PR must be merged before a backport PR will be created. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-13684-to-k212 origin/k212
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 5a87ccb648ee3bf48a3704643ae9923d64651aed When the conflicts are resolved, stage and commit the changes:
If you have the GitHub CLI installed: # Push the branch to GitHub:
git push --set-upstream origin backport-13684-to-k212
# Create the PR body template
PR_BODY=$(gh pr view 13684 --json body --template 'Backport 5a87ccb648ee3bf48a3704643ae9923d64651aed from #13684{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title 'chore: [k212] feat: instrument failed chunk encoding/decoding' --body-file - --label 'size/L' --label 'product-approved' --label 'backport' --base k212 --milestone k212 --web Or, if you don't have the GitHub CLI installed (we recommend you install it!): # Push the branch to GitHub:
git push --set-upstream origin backport-13684-to-k212
# Create a pull request where the `base` branch is `k212` and the `compare`/`head` branch is `backport-13684-to-k212`.
# Remove the local backport branch
git switch main
git branch -D backport-13684-to-k212 |
trevorwhitney
added a commit
that referenced
this pull request
Jul 26, 2024
(cherry picked from commit 5a87ccb)
benclive
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Jul 31, 2024
This was referenced Aug 15, 2024
This was referenced Oct 14, 2024
This was referenced Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is related to problems we've seen with corrupted chunks. These corruptions are very rare, making it hard to troubleshoot. This instrumentation should allow us to alert on and track occurrences to help us investigate when they happen.