Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: instrument failed chunk encoding/decoding #13684

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

trevorwhitney
Copy link
Collaborator

What this PR does / why we need it:

This is related to problems we've seen with corrupted chunks. These corruptions are very rare, making it hard to troubleshoot. This instrumentation should allow us to alert on and track occurrences to help us investigate when they happen.

@trevorwhitney trevorwhitney requested a review from a team as a code owner July 26, 2024 21:25
@trevorwhitney trevorwhitney merged commit 5a87ccb into main Jul 26, 2024
63 checks passed
@trevorwhitney trevorwhitney deleted the observe-corrupted-chunks branch July 26, 2024 22:12
@grafanabot
Copy link
Collaborator

This PR must be merged before a backport PR will be created.

1 similar comment
@grafanabot
Copy link
Collaborator

This PR must be merged before a backport PR will be created.

@grafanabot
Copy link
Collaborator

The backport to k212 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-13684-to-k212 origin/k212
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 5a87ccb648ee3bf48a3704643ae9923d64651aed

When the conflicts are resolved, stage and commit the changes:

git add . && git cherry-pick --continue

If you have the GitHub CLI installed:

# Push the branch to GitHub:
git push --set-upstream origin backport-13684-to-k212
# Create the PR body template
PR_BODY=$(gh pr view 13684 --json body --template 'Backport 5a87ccb648ee3bf48a3704643ae9923d64651aed from #13684{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title 'chore: [k212] feat: instrument failed chunk encoding/decoding' --body-file - --label 'size/L' --label 'product-approved' --label 'backport' --base k212 --milestone k212 --web

Or, if you don't have the GitHub CLI installed (we recommend you install it!):

# Push the branch to GitHub:
git push --set-upstream origin backport-13684-to-k212

# Create a pull request where the `base` branch is `k212` and the `compare`/`head` branch is `backport-13684-to-k212`.

# Remove the local backport branch
git switch main
git branch -D backport-13684-to-k212

trevorwhitney added a commit that referenced this pull request Jul 26, 2024
benclive pushed a commit to cyriltovena/loki that referenced this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants