Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Read full buffer from storage when fetching a range #13948

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

benclive
Copy link
Contributor

What this PR does / why we need it:
Fixes an issue in RF-1 queries where we didn't read the full object storage response because it wasn't available yet.

  • io.ReadFull handles EOF errors so we no longer need to check for them. We'll get unexpected EOF if something goes wrong.

@benclive benclive requested a review from a team as a code owner August 22, 2024 10:34
@benclive benclive merged commit 115fef4 into main Aug 22, 2024
63 checks passed
@benclive benclive deleted the benclive/fix-rf1-chunk-downloads branch August 22, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants