Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing chunkDelimiter parameter for Azure storage in Helm chart #14010

Closed
NGPixel opened this issue Aug 30, 2024 · 2 comments · Fixed by #14011
Closed

Missing chunkDelimiter parameter for Azure storage in Helm chart #14010

NGPixel opened this issue Aug 30, 2024 · 2 comments · Fixed by #14011

Comments

@NGPixel
Copy link
Contributor

NGPixel commented Aug 30, 2024

Describe the bug
The Loki helm chart is missing the loki.storage.azure.chunkDelimiter parameter. This is needed when migrating from S3 (which uses :) to Azure Blob Storage (which uses - by default (why?!)).

To Reproduce
Steps to reproduce the behavior:

  1. Set loki.storage.azure.chunkDelimiter to :
  2. Deploy to Kubernetes
  3. Delimiter is still using - because parameter is not set in the template.

Expected behavior
Being able to set chunkDelimiter as part of the helm values.

Environment:

  • Infrastructure: Kubernetes
  • Deployment tool: helm

Screenshots, Promtail config, or terminal output
N/A

@vlad-diachenko
Copy link
Contributor

Hey @NGPixel . by default we replace : with - because Azure did not support a colon in object name through the SDK Loki uses under the hood.
So, I believe it's useful to be able to customize chunkDelimiter in the helm chart but be aware that using a colon might bring the issue to your setup(not sure, because maybe Azure SDK already fixed the issue).

@ubcharron
Copy link

ubcharron commented Oct 17, 2024

I think there's an issue issue with quoting. In chart version 6.18, helm fails to generate the template if I set chunkDelimiter to ":"

loki:
  storage:
    azure:
      chunkDelimiter: ":"

Error: 'error converting YAML to JSON: yaml: line 35: mapping values are not allowed in this context

I need to set it as follows for it to work:

chunkDelimiter: "\":\""

(And if it helps anybody else, I can confirm that Loki 3.2.0 works as expected when chunkDelimiter is set to ":" with Azure blob storage)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants