feat(distributors): Use a pool of worker to push to ingesters. #14245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type/docs
na--
reviewed
Sep 24, 2024
pkg/distributor/distributor.go
Outdated
| return services.StartManagerAndAwaitHealthy(ctx, d.subservices) | ||
| } | ||
|
|
||
| func (d *Distributor) running(ctx context.Context) error { | ||
| defer func() { | ||
| close(d.ingesterTasks) |
There was a problem hiding this comment.
I am not 100% sure, but I think it might be possible for this to cause a panic 🤔 If we are in the middle of a Distributor.Push() call when the context gets cancelled, we might close d.ingesterTasks here right before we try to add to it here:
loki/pkg/distributor/distributor.go
Line 653 in 0738dd0
There was a problem hiding this comment.
Change a bit the shutdown logic.
LashaJini
pushed a commit
to LashaJini/loki
that referenced
this pull request
Sep 26, 2024
jeschkies
pushed a commit
to jeschkies/loki
that referenced
this pull request
Oct 1, 2024
This was referenced Oct 14, 2024
This was referenced Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This introduce a pool to push to ingesters to avoid spawning a new goroutine each time and release go runtime scheduler.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR