Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jsonnet): Allow to name prefix zoned ingesters #14260

Merged
merged 1 commit into from
Sep 26, 2024
Merged

feat(jsonnet): Allow to name prefix zoned ingesters #14260

merged 1 commit into from
Sep 26, 2024

Conversation

cyriltovena
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@cyriltovena cyriltovena requested a review from a team as a code owner September 25, 2024 13:18
ashwanthgoli
ashwanthgoli approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@ashwanthgoli ashwanthgoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit fac3177 into main Sep 26, 2024
64 checks passed
@cyriltovena cyriltovena deleted the add-prefix-name-ingester-zone branch September 26, 2024 07:52
LashaJini pushed a commit to LashaJini/loki that referenced this pull request Sep 26, 2024
@cyriltovena @LashaJini
feat(jsonnet): Allow to name prefix zoned ingesters (grafana#14260)
4b4ad12
@loki-gh-app loki-gh-app bot mentioned this pull request Sep 30, 2024
Open
jeschkies pushed a commit to jeschkies/loki that referenced this pull request Oct 1, 2024
@cyriltovena @jeschkies
feat(jsonnet): Allow to name prefix zoned ingesters (grafana#14260)
0a72aaa
@loki-gh-app loki-gh-app bot mentioned this pull request Oct 7, 2024
Open
This was referenced Oct 14, 2024
Open
Closed
This was referenced Oct 21, 2024
Open
Open
@loki-gh-app loki-gh-app bot mentioned this pull request Nov 4, 2024
Merged
@loki-gh-app loki-gh-app bot mentioned this pull request Nov 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwanthgoli ashwanthgoli ashwanthgoli approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyriltovena @ashwanthgoli