Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kafka): Implement limiter using partition ring for Kafka #14359

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

benclive
Copy link
Contributor

@benclive benclive commented Oct 2, 2024

What this PR does / why we need it:

Adds a partition ring strategy to stream limiting. This is needed for the kafka-based write path.

  • Extracts the global limit -> local limit logic into "strategies" - one for regular ingester ring and one using the partition ring
  • Updates tests: Whereever we just need a working limiter and aren't testing it explicitly, I used the old strategy.

Which issue(s) this PR fixes:
Fixes https://github.com/grafana/loki-private/issues/1118

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@benclive benclive requested a review from a team as a code owner October 2, 2024 16:44
@benclive benclive force-pushed the benclive/implement-limiter-with-kafka branch from b172aa9 to 6a09a6e Compare October 3, 2024 15:12
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 5cbb239 into main Oct 4, 2024
60 checks passed
@cyriltovena cyriltovena deleted the benclive/implement-limiter-with-kafka branch October 4, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants