feat: Do not add empty blooms to offsets #14577
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Series w/o structured metadata are appended to blocks with empty blooms, even though empty blooms are small, this adds up among all the blocks. This also prevent us from experimenting with single-stream blocks since we'd end up with many tiny blocks with empty blooms.
This PR solves this by only appending series to the index section if the series yield empty blooms, but not populating the offsets for the series. Now if we want to try out single-stream blocks, we can:
This is obviously not optimal, but will allow us to test out single-stream blocks with what we currently have.
Besides allowing us to test single-stream blocks, this PR would also be beneficial to reduce the total size of the blocks by not appending empty blooms at all.
This PR also fixes the maximum block size since we did not look at the unflushed index and blooms pages size.
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
deprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR