Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: logcli: Check for errors before checking for exists when fetching data #14780

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

DylanGuedes
Copy link
Contributor

What this PR does / why we need it:
When getting data from object storage, we're first checking for the exists return and only then for the error returned. Everytime an error is returned an exists=false is also returned, and that is taken more precedence than the error itself.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@DylanGuedes DylanGuedes requested a review from a team as a code owner November 5, 2024 18:51
Copy link
Contributor

@poyzannur poyzannur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested that it actually returns correct errors with this fix xD
Instead of Query failed: doesn't exist for everything.
finally i got Query failed: NoCredentialProviders: no valid providers in chain.
Thanks Dylan!!

@DylanGuedes DylanGuedes merged commit 9e7d2f2 into main Nov 6, 2024
61 checks passed
@DylanGuedes DylanGuedes deleted the fix-logcli-logging branch November 6, 2024 19:01
@DylanGuedes DylanGuedes added type/bug Somehing is not working as expected backport release-3.2.x labels Nov 8, 2024
loki-gh-app bot pushed a commit that referenced this pull request Nov 8, 2024
loki-gh-app bot pushed a commit that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants