-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(aggregated_metrics): Fix the IsError method causing retries #15296
Conversation
Hello @shantanualsi!
Please, if the current pull request addresses a bug fix, label it with the |
Co-authored-by: Ned Andreev <n@andreev.sh>
This PR must be merged before a backport PR will be created. |
Co-authored-by: Ned Andreev <n@andreev.sh> (cherry picked from commit 7a7b3b1)
Co-authored-by: Ned Andreev <n@andreev.sh> (cherry picked from commit 7a7b3b1)
What this PR does / why we need it:
The IsError method does not return true even though status is 204. This is causing retries that makes aggregated metrics incorrect.
This PR fixes it and adds some tests.
#incident-2024-12-05-metric-aggregation-is-broken
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
deprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR