Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aggregated_metrics): Fix the IsError method causing retries #15296

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

shantanualsi
Copy link
Contributor

@shantanualsi shantanualsi commented Dec 6, 2024

What this PR does / why we need it:
The IsError method does not return true even though status is 204. This is causing retries that makes aggregated metrics incorrect.
This PR fixes it and adds some tests.

#incident-2024-12-05-metric-aggregation-is-broken

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@shantanualsi shantanualsi changed the title Fix the IsError method causing retries fix(aggregated_metrics): Fix the IsError method causing retries Dec 6, 2024
@shantanualsi shantanualsi marked this pull request as ready for review December 6, 2024 07:36
@shantanualsi shantanualsi requested a review from a team as a code owner December 6, 2024 07:36
@loki-gh-app
Copy link
Contributor

loki-gh-app bot commented Dec 6, 2024

Hello @shantanualsi!
Backport pull requests need to be either:

  • Pull requests which address bugs,
  • Urgent fixes which need product approval, in order to get merged,
  • Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If the pull request modifies CI behaviour, please add the type/ci label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

pkg/util/http.go Outdated Show resolved Hide resolved
Co-authored-by: Ned Andreev <n@andreev.sh>
@shantanualsi shantanualsi added the type/bug Somehing is not working as expected label Dec 6, 2024
@loki-gh-app
Copy link
Contributor

loki-gh-app bot commented Dec 6, 2024

This PR must be merged before a backport PR will be created.

@shantanualsi shantanualsi merged commit 7a7b3b1 into main Dec 6, 2024
60 checks passed
@shantanualsi shantanualsi deleted the shantanu/fix-aggregated-metrics branch December 6, 2024 09:55
loki-gh-app bot pushed a commit that referenced this pull request Dec 6, 2024
Co-authored-by: Ned Andreev <n@andreev.sh>
(cherry picked from commit 7a7b3b1)
loki-gh-app bot pushed a commit that referenced this pull request Dec 6, 2024
Co-authored-by: Ned Andreev <n@andreev.sh>
(cherry picked from commit 7a7b3b1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport k230 backport k231 size/M type/bug Somehing is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants