Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable metric aggregation in loki-local-config.yaml (backport release-3.3.x) #15319

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

loki-gh-app[bot]
Copy link
Contributor

@loki-gh-app loki-gh-app bot commented Dec 9, 2024

Backport c96b750 from #15302


What this PR does / why we need it:

Metric aggregation was move to a per-tenant config. #15059 removed the old global config, but forgot to add the new limit override. This adds the limit override to loki-local-config.yaml so that metric aggregation is enabled in that config.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@loki-gh-app loki-gh-app bot requested a review from a team as a code owner December 9, 2024 18:47
@loki-gh-app loki-gh-app bot added backport size/XS type/bug Somehing is not working as expected labels Dec 9, 2024
@loki-gh-app loki-gh-app bot requested a review from trevorwhitney December 9, 2024 18:47
@trevorwhitney trevorwhitney merged commit 635f04d into release-3.3.x Dec 9, 2024
65 checks passed
@trevorwhitney trevorwhitney deleted the backport-15302-to-release-3.3.x branch December 9, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport size/XS type/bug Somehing is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants