Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the docker driver build (backport release-3.3.x) #15478

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

trevorwhitney
Copy link
Collaborator

Backport 4d71ca3 from #15354


What this PR does / why we need it:

#9247 did not seem to fix the docker driver build. It first failed because of the an incorrect prefix in the job definition, and after that was fixed it failed again because of an undefined env variable.

Depends on grafana/loki-release#165

Which issue(s) this PR fixes:
Fixes #5682, #15318

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@trevorwhitney trevorwhitney added size/L backport type/bug Somehing is not working as expected product-approved labels Dec 18, 2024
@trevorwhitney trevorwhitney requested a review from a team as a code owner December 18, 2024 15:56
@trevorwhitney trevorwhitney changed the title ci: fix the docker driver build (backport release-3.3.x) fix: fix the docker driver build (backport release-3.3.x) Dec 18, 2024
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trevorwhitney trevorwhitney merged commit 23b5fc2 into release-3.3.x Dec 18, 2024
61 checks passed
@trevorwhitney trevorwhitney deleted the backport-15354-to-release-3.3.x branch December 18, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport product-approved size/L type/bug Somehing is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants