Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: structured metadata not always passed down for processing deletes #15526

Merged
merged 1 commit into from
Dec 20, 2024
Merged

fix: structured metadata not always passed down for processing deletes #15526

merged 1 commit into from
Dec 20, 2024

Conversation

slim-bean
Copy link
Collaborator

@slim-bean slim-bean commented Dec 20, 2024 •
edited
Loading

What this PR does / why we need it:
Structured metadata was not passed downstream when a delete request pipeline filter was processed for a query (only affected metric queries).

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@slim-bean
fix: structured metadata was not passed downstream when a delete requ…
5ed0c4f 
…est pipeline filter was processed for a query (only affected metric queries).

Signed-off-by: Edward Welch <edward.welch@grafana.com>
@slim-bean slim-bean requested a review from a team as a code owner December 20, 2024 20:42
@rfratto rfratto changed the title fix: structured metadata was not passed downstream when a delete requ… fix: structured metadata not always passed down for processing deletes Dec 20, 2024
@slim-bean slim-bean merged commit a3808b6 into main Dec 20, 2024
60 checks passed
@slim-bean slim-bean deleted the fix-delete-processing-structured-metadata branch December 20, 2024 20:56
@slim-bean slim-bean added type/bug Somehing is not working as expected backport k233 labels Dec 20, 2024
loki-gh-app bot pushed a commit that referenced this pull request Dec 20, 2024
@slim-bean @grafana-delivery-bot
fix: structured metadata not always passed down for processing deletes (
0486b4b 
#15526)

Signed-off-by: Edward Welch <edward.welch@grafana.com>
(cherry picked from commit a3808b6)
@loki-gh-app loki-gh-app bot mentioned this pull request Dec 20, 2024
Merged
6 tasks
loki-gh-app bot pushed a commit that referenced this pull request Dec 21, 2024
@slim-bean @grafana-delivery-bot
fix: structured metadata not always passed down for processing deletes (
2450452 
#15526)

Signed-off-by: Edward Welch <edward.welch@grafana.com>
(cherry picked from commit a3808b6)
This was referenced Dec 21, 2024
Merged
Open
This was referenced Dec 30, 2024
Open
Open
mveitas pushed a commit to mveitas/loki that referenced this pull request Jan 6, 2025
@slim-bean @mveitas
fix: structured metadata not always passed down for processing deletes (
24e25d2 
grafana#15526)

Signed-off-by: Edward Welch <edward.welch@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MasslessParticle MasslessParticle MasslessParticle approved these changes

Assignees
No one assigned
Labels
backport k232 backport k233 size/XS type/bug Somehing is not working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slim-bean @MasslessParticle